User "Reedy" changed the status of MediaWiki.r95698. Old Status: new New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95698 Commit summary: Apply coding conventions: * Spaces to tabs * Spaces after a ',' in globals list. * Api-classes starting with "Api" * SpecialPage-classes with format Special{Name}. Renamed SignupForm class to SpecialUserSignup. * Filenames matching classes they define * No global functions, instead put hook functions inside a static hooks class Best practices: * Don't conditionally define a function * No need for the 'global' keyword in the config as this is running in the global context already * Move a file with 'svn move', not with delete and re-add. That way properties and commit history stays preserved. (I deleted ValidateSignup.php, and reverted r95213 to get the original validateSignup.php back and then renamed it to ApiValidateSignup.php) Issues fixed: * usersignup was listed on Special:SpecialPages under 'other'. Added it to 'login' group instead. * Removed usage of inexistent module 'mediawiki.special.usersignup' _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
