User "Pgehres (WMF)" changed the status of Wikimedia.r329. Old Status: new New Status: ok
User "Pgehres (WMF)" also posted a comment on Wikimedia.r329. Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/329#c22833 Commit summary: Patched mine_squid_landing_page_requests() to handle agent strings that cannot be properly parsed by httpagentparser Comment: Although the error would be handled by the blanket except, a better way to test for the existence of values not being empty in the user_agent_fields array is would be to do something like: if not user_agent_fields['browser']: ... This ensures that you don't throw TypeError(s) with the call to len(). See more: http://docs.python.org/library/stdtypes.html Section 5.1 _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
