User "Krinkle" posted a comment on MediaWiki.r74966.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/74966#c22861
Commit summary:
First shot at porting Monobook to Vector. The only non-straightforward part is
moving from a separate rtl.css file to a main.css file we can safely Janus.
This is half-done right now. Notable things:
* No longer including rtl.css, instead relying on Janused main.css
* Renamed external.png to external-ltr.png so Janus will pick up on
external-rtl.png (already exists)
* Added @embed to all images, add @noflip where needed (may not have covered
all cases)
* Pulled some things from rtl.css into main.css such that they're no-ops in LTR
but are needed in RTL. Example: body { direction:ltr;
* Killed some RTL-specific rules in main.css that were superseded in main.css
* Changed padding: 0 foo; to padding-right: foo; so it gets Janused right
* Commented out loading of IE*Fixes.css. Still need to incorporate these into
main.css somehow
Comment:
IE5 should not be an issue imho as it's no longer supported. The content should
visible and readable (which it is).
IE''6'' and IE7 still need attention though.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
