User "Brion VIBBER" changed the status of MediaWiki.r79845. Old Status: resolved New Status: fixme
User "Brion VIBBER" also posted a comment on MediaWiki.r79845. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/79845#c22870 Commit summary: $wgMaxUploadSize may now be set to an array to specify the upload size limit per upload type. Backwards compatible, if not set to an array, applies to all uploads. If set to an array, per upload type maximums can be set, using the file and url keys. If the * key is set this value will be used as maximum for non-specified types. Comment: Several things appear to be visibly wrong, and still exposed as of current trunk and bug 31024 etc: * width & height reported for an image from BitmapHandler are not being normalized to the post-rotation values, and thus get reported on through via $file->getWidth(), $file->getHeight() etc * lots and lots of stuff gets confused and sizes things to something other than what you asked for; for instance asking for a portrait image rendered to fit an 800x600 box may give you a 600x800 image instead of 450x600 (and per bug 31024 thumb.php will render the 450x600 after being *asked* for 600x800, when we should have asked for 450x600. aaaaaargh) _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
