User "Trevor Parscal" posted a comment on MediaWiki.r97685. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97685#c22884 Commit summary:
Added initial html and css that UI will be built from. Comment: 1. Since the assets will end up in the SVN eventually anyways, it produces duplication - if you update the svn copy, should you update the wiki too? Probably not ideal. 2. It took me a extra time to grab all the images off the page, then rename them to something sane for use in a web page, then move them to the extension folder - this took more time than I expected. I think it would be better if you just emailed me a zip file of the sliced images, using the common lowercase hyphenated naming style. Given how bad our upload system is, I imagine you spent a bit more time than you would have preferred as well. Handing off a zip will save developers and designers time. Also, you uploaded lots of images that were not needed for version 1, and I noticed that the more arrow was not there at all. I just used one of the downward facing 60 degree arrows, but the design called for a 90 degree arrow (maybe this is a design flaw, since it's inconsistent with all other arrows?) _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
