User "Aaron Schulz" changed the status of MediaWiki.r97367. Old Status: ok New Status: fixme
User "Aaron Schulz" also posted a comment on MediaWiki.r97367. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97367#c22889 Commit summary: [ResourceLoader] Set default options for gadgets that are enabled by default, otherwise they can't be disabled from the preferences (bug 30941) * Uses the new hook in User:getDefaultOptions (bug 30940; r97365) * This revision is based on a similar one for RL2 in the branch (r97366). Needs to be back ported as the bug occurs in 1.18 as well Comment: Unstub loop detected on call of $wgLang->getCode from MessageCache::get Backtrace: #0 C:\wamp\www\MW_trunk\includes\StubObject.php(57): StubObject->_unstub('getCode', 5) #1 C:\wamp\www\MW_trunk\includes\StubObject.php(147): StubObject->_call('getCode', Array) #2 [internal function]: StubUserLang->__call('getCode', Array) #3 C:\wamp\www\MW_trunk\includes\cache\MessageCache.php(606): StubUserLang->getCode() #4 C:\wamp\www\MW_trunk\includes\GlobalFunctions.php(1355): MessageCache->get('gadgets-definit...', true, false) #5 C:\wamp\www\MW_trunk\extensions\Gadgets\Gadgets_body.php(510): wfEmptyMsg('gadgets-definit...', '== interface-ga...') #6 C:\wamp\www\MW_trunk\extensions\Gadgets\Gadgets_body.php(38): Gadget::loadStructuredList() #7 [internal function]: GadgetHooks::userGetDefaultOptions(Array) #8 C:\wamp\www\MW_trunk\includes\Hooks.php(216): call_user_func_array('GadgetHooks::us...', Array) #9 C:\wamp\www\MW_trunk\includes\GlobalFunctions.php(3642): Hooks::run('UserGetDefaultO...', Array) #10 C:\wamp\www\MW_trunk\includes\User.php(1217): wfRunHooks('UserGetDefaultO...', Array) #11 C:\wamp\www\MW_trunk\includes\User.php(2150): User::getDefaultOptions() #12 C:\wamp\www\MW_trunk\includes\context\RequestContext.php(192): User->getOption('language') #13 C:\wamp\www\MW_trunk\includes\StubObject.php(151): RequestContext->getLang() #14 C:\wamp\www\MW_trunk\includes\StubObject.php(103): StubUserLang->_newObject() #15 C:\wamp\www\MW_trunk\includes\StubObject.php(57): StubObject->_unstub('getCode', 5) #16 C:\wamp\www\MW_trunk\includes\StubObject.php(147): StubObject->_call('getCode', Array) #17 [internal function]: StubUserLang->__call('getCode', Array) #18 C:\wamp\www\MW_trunk\includes\cache\MessageCache.php(606): StubUserLang->getCode() #19 C:\wamp\www\MW_trunk\includes\GlobalFunctions.php(1355): MessageCache->get('gadgets-definit...', true, false) #20 C:\wamp\www\MW_trunk\extensions\Gadgets\Gadgets_body.php(510): wfEmptyMsg('gadgets-definit...', '== interface-ga...') #21 C:\wamp\www\MW_trunk\extensions\Gadgets\Gadgets_body.php(38): Gadget::loadStructuredList() #22 [internal function]: GadgetHooks::userGetDefaultOptions(Array) #23 C:\wamp\www\MW_trunk\includes\Hooks.php(216): call_user_func_array('GadgetHooks::us...', Array) #24 C:\wamp\www\MW_trunk\includes\GlobalFunctions.php(3642): Hooks::run('UserGetDefaultO...', Array) #25 C:\wamp\www\MW_trunk\includes\User.php(1217): wfRunHooks('UserGetDefaultO...', Array) #26 C:\wamp\www\MW_trunk\includes\User.php(2150): User::getDefaultOptions() #27 C:\wamp\www\MW_trunk\includes\context\RequestContext.php(192): User->getOption('language') #28 C:\wamp\www\MW_trunk\includes\StubObject.php(151): RequestContext->getLang() #29 C:\wamp\www\MW_trunk\includes\StubObject.php(103): StubUserLang->_newObject() #30 C:\wamp\www\MW_trunk\includes\StubObject.php(57): StubObject->_unstub('getCode', 5) #31 C:\wamp\www\MW_trunk\includes\StubObject.php(147): StubObject->_call('getCode', Array) #32 [internal function]: StubUserLang->__call('getCode', Array) #33 C:\wamp\www\MW_trunk\includes\cache\HTMLFileCache.php(111): StubUserLang->getCode() #34 C:\wamp\www\MW_trunk\includes\Wiki.php(601): HTMLFileCache::useFileCache() #35 C:\wamp\www\MW_trunk\includes\Wiki.php(530): MediaWiki->main() #36 C:\wamp\www\MW_trunk\index.php(58): MediaWiki->run() #37 {main} _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
