User "Raindrift" posted a comment on MediaWiki.r96873. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96873#c22972 Commit summary:
work around ffmpeg seeking issues in ogg files Comment: Does this make sense even when the keyframe interval is greater than 48 (for 24fps video) or 60 (for 30fps)? It's not uncommon to see videos with a keyframe every 240 p-frames or more. I'm not familiar enough with the code yet to know what video metadata is available, but if you know the keyframe interval and framerate, it might make sense to use them here. If not, maybe it doesn't really matter... thumbnailing doesn't have to be too precise, right? :) _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
