User "Tim Starling" changed the status of MediaWiki.r97328. Old Status: new New Status: fixme
User "Tim Starling" also posted a comment on MediaWiki.r97328. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97328#c22979 Commit summary: Noticed in apache error logs (see below). If the length of the message is longer than the maximum length, only send what will fit Sep 16 20:07:28 10.0.2.193 apache2[28441]: PHP Warning: socket_sendto() [<a href='function.socket-sendto'>function.socket-sendto</a>]: unable to write to socket [90]: Message too long in /home/wikipedia/common/php-1.17-test/includes/GlobalFunctions.php on line 464 Sep 16 20:07:29 10.0.2.193 apache2[26511]: PHP Warning: socket_sendto() [<a href='function.socket-sendto'>function.socket-sendto</a>]: unable to write to socket [90]: Message too long in /home/wikipedia/common/php-1.17-test/includes/GlobalFunctions.php on line 464 Comment: This is wrong. SO_SNDBUF is 124KB by default, which is much larger than the maximum UDP packet size of 64KB. <pre> > print socket_get_option( $sock, SOL_SOCKET, SO_SNDBUF ) 126976 > $l = 65507; socket_sendto($sock, str_repeat('x',$l), $l, 0, '127.0.0.1', > 1111); > $l = 65508; socket_sendto($sock, str_repeat('x',$l), $l, 0, '127.0.0.1', > 1111); PHP Warning: socket_sendto(): unable to write to socket [90]: Message too long in /home/tstarling/src/mediawiki/trunk/phase3/maintenance/eval.php(79) : eval()'d code on line 1 </pre> _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
