User "Awjrichards" changed the status of MediaWiki.r97776. Old Status: new New Status: fixme
User "Awjrichards" also posted a comment on MediaWiki.r97776. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97776#c23028 Commit summary: Adding webitects form for this week as well as a few changes to RapidHTML Comment: The field name 'currency' gets used in multiple places throughout here - it should be 'currency_code'. This is what is expected by DonationInterface. In the form, I see you are creating hidden fields for both 'currency' and 'currency_code', but only 'currency' is getting posted at form submission, likely due to the Javascript magic at the end of the form file. Also, with RapidHtml forms, the PayPal redirect needs to be handled differently than with the landing pages: <pre> + // set the action to go to PayPal + /****************** + ** TODO: FIX ME ** (Broken on return to form from PP and then choose CC) + ******************/ + $("input[name=gateway]").val("paypal"); + document.paypalcontribution.action = "https://wikimediafoundation.org/wiki/Special:ContributionTracking/en";; + $("#loading").html("<img src='../images/loading.gif' /> Redirecting to PayPal…"); + document.paypalcontribution.submit(); + } + }); </pre> iirc, the PayPal redirect should happen via DonationInterface to ensure tracking data is properly set. the 'PaypalRedirect' should get set to true and posted back to DonationInterface, which should take care of the rest. Also, you seem to have changed from tabs -> spaces in RapidHtml.php, which I believe is why the diff is showing that the entire file changed. Besides being counter to MediaWiki convention (http://www.mediawiki.org/wiki/Coding_conventions#File_formatting), this means I cannot easily code review this file. Please fix. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
