User "Siebrand" posted a comment on MediaWiki.r97851. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97851#c23049 Commit summary:
followup r79862: the for loop only cleans up half the output handlers (since $i counts up while ob_get_level() counts down); check the return value of ob_end_clean() instead. (I just noticed this while eyeballing the code -- apparently most people don't have multiple output handlers active, given that nobody had caught this in over eight months.) Comment: Niklas is reverting. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
