User "Reedy" posted a comment on MediaWiki.r95861. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95861#c23056 Commit summary:
Followup r95197, fixed code to display extension specific messages Comment: Adding to the latest revision for ease... Few issues: * On SpecialUserSignup ** Line 443 $tempUser is undefined ** Line 479 $ip is undefined ** Line 495 $valid is undefined ** Line 516 $abortError is undefined ** Line 931, $this->successfulLogin() is undefined * On ApiSignup ** Line 56 the hook call for "UserLoginComplete" seems useless on an signup form ** Line 59 the hook BeforeWelcomeCreation seems useless as the information isn't returned or anything else * On ApiValidateSignup ** The api shouldn't in most cases be parsing messages for return in the result. Passing just a set string is enough. Same for the images being returned. It would look like in verification.js you're doing some stuff with the images there too * SignupAPI.hooks ** Rather than building query strings yourself, you should look at using wfAppendQuery() Question: Which version of MediaWiki did you develop this against? Few bits that against trunk is pointing at deprecated code, but that is a minor issue. Any chance you could address these issues? Thanks! _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
