User "Santhosh.thottingal" changed the status of MediaWiki.r97606.

Old Status: new
New Status: ok

User "Santhosh.thottingal" also posted a comment on MediaWiki.r97606.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97606#c23073
Commit summary:

Narayam: Blank keybuffer was matching against rules that require keybuffer 
match. Fixed now.

Comment:

f ( keyBufferMatch && regex.test( str ) )  - this condition was doing input 
string matching and keyBufferMatch assertion. Now keyBufferMatch is doing only 
after regex.test( str  is passed, there by avoid unnecessary checks even if 
keybuffer is empty or even the rule does not match with input string itself. 

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to