User "Khorn (WMF)" changed the status of Wikimedia.r481. Old Status: new New Status: fixme
User "Khorn (WMF)" also posted a comment on Wikimedia.r481. Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/481#c23134 Commit summary: Added stomp, activeMQ and txId setters, getters and tests. Comment: <pre>+ 'activeMqStompUri' => $activeMqStompUri,</pre> Rather than hard-coding variables like this, they should be pulling from a configurable .ini file which should be left out of the repo for security reasons. (Instead, commit an example .ini-conf) Any variables that deal with site-specific configuration need to be handled in a similar manner. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
