User "Happy-melon" posted a comment on MediaWiki.r93246. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93246#c23175 Commit summary:
(bug 15641) prevent blocked administrators from accessing deleted revisions. Comment: So instead you want to do what? Hack User::isAllowed() to specialcase <tt>deletedhistory</tt> and thereby pollute one of the few functions in User.php that actually does what it says on the tin? The best way to implement this and various other block-related permissions issues would probably be to make being blocked add users to an implicit group, then we can use the existing $wgRevokePermissions infrastructure to do this nicely (and within the context of what User->isAllowed() is correctly testing). But that's a big job that shouldn't prejudice this specific fix. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
