User "Pgehres (WMF)" changed the status of Wikimedia.r311. Old Status: new New Status: fixme
User "Pgehres (WMF)" also posted a comment on Wikimedia.r311. Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/311#c23362 Commit summary: DataMapper now handles checking for the latest logs in the local directory, copying them if they're not there, then mining the copied logs Added a wrapper script that initiates log copy and mining process Comment: FIXME: The call to sys.exit is unnecessary in run_log_miner.py. I would prefer to not "import sys" unless absolutely necessary (makes it much easier to spot syscalls when it is added to the import list). I see that you are also using to append the project to the $PATH, but I don't think that you should have to. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
