User "Pgehres (WMF)" changed the status of Wikimedia.r396. Old Status: new New Status: fixme
User "Pgehres (WMF)" also posted a comment on Wikimedia.r396. Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/396#c23377 Commit summary: removed from views os package references to change working directory. Instead (correctly) using path from local settings file. moved generic execute_SQL() method to DataLoader base class. now returns results. Comment: FIXME: the function execute_SQL starting at line 204 of DataLoader.py worries me. Is there a better way that this can be structured so that we can ensure that the SQL being executed is safe? _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
