User "Aaron Schulz" changed the status of MediaWiki.r98012. Old Status: new New Status: fixme
User "Aaron Schulz" also posted a comment on MediaWiki.r98012. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98012#c23383 Commit summary: Allow LogEventsList::showLogExtract() to get a Title object instead of having to do Title -> string -> Title conversion Comment: <pre> + * @param $page String or Title object: Title name </pre> Can you use "String|null" instead? In LogEventsList.php: <pre> 696 if ( $page != '') 697 $urlParam['page'] = $page; </pre> How does this work now? showLogExtract() docs were not updated wrt to $page <pre> 721 if (!wfRunHooks('LogEventsListShowLogExtract', array(&$s, $types, $page, $user, $param))) { </pre> Hooks docs need updating or this should make sure $page is a string. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
