User "Aaron Schulz" posted a comment on MediaWiki.r96828. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96828#c23393 Commit summary:
* Use local context instead of global variables (where possible) * Made getFormFields() non-static since the only call to it is in that file Comment: Why did you make getFormFields() dynamic? Why not just pass in a $user object. Perhaps someone might want to refactor this function for more general use outside the special page. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
