User "Tim Starling" changed the status of MediaWiki.r83909.

Old Status: resolved
New Status: fixme

User "Tim Starling" also posted a comment on MediaWiki.r83909.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83909#c23421
Commit summary:

Complete the trinity of blocking frontend interfaces by rewriting 
SpecialIpblocklist:
* Move and rename to SpecialBlockList
* Use an HTMLForm in GET mode for the options form
* Use TablePager to organise the results more nicely
* Standardise the filtration for IPs and IP ranges, so looking at blocks for a 
range will now also show rangeblocks which contain the range
* General tidy up

Comment:

This is a serious performance regression. Removing the LinkBatch and 
ipb_by_text code results in 3 DB queries being done for each block, with a 
noticeable performance impact in production.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to