User "Aaron Schulz" changed the status of MediaWiki.r84534.

Old Status: ok
New Status: fixme

User "Aaron Schulz" also posted a comment on MediaWiki.r84534.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84534#c23424
Commit summary:

(hopefully) last bit of heavy lifting in Block.php: now that we've internalised 
most of the variables, untangle their twisted connections to the database layer 
and remove various now-unused protected methods and variables.

Comment:

The removal of $byName severaly broke CentralAuth crossWiki suppression blocks. 
A live hack is running on the WMF wikis. See:
01:20 logmsgbot: tstarling synchronized 
php-1.17/includes/specials/SpecialIpblocklist.php 'privacy patch'

CA relied on being able to set an arbitrary blocker name but with an ID of 
zero, which is slightly tricky to do now.

A hacky patch to fix CA is at http://pastebin.com/Ead2eYf3.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to