User "Jeroen De Dauw" posted a comment on MediaWiki.r98488.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98488#c23523
Commit summary:
refactoring nessasery because of changes in r98036
readParameters -> handleParameters
Comment:
Gallery is not using this function at all no? In any case, the problems with
this commit are that although the clear fatal error will go away, many other
issue will still be there, some of which will be very subtle. So it's important
to not see this as a full fix. Also, the method signature is wrong, it should
be
protected function handleParameters( '''array''' $params, $outputmode ) {
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
