User "Trevor Parscal" changed the status of MediaWiki.r97788. Old Status: new New Status: fixme
User "Trevor Parscal" also posted a comment on MediaWiki.r97788. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97788#c23577 Commit summary: Zero padding for #firstHeading makes text cut for scripts like Devanagari , Malayalam etc(Bug 29405 and Bug 30809), especially when the glyphs are stacked or having lower diacritic marks. Remove padding-top:0 and padding-bottom:0 to allow h1 inherit the padding bottom and top values from commonElements.css fixes this. Comment: This should be reverted because it causes the first heading to have too much space above it. The correct approach would be to locally, or at least specifically, target this language with CSS. For example, you might want to use something like this... html[lang=hi] h1, html[lang=hi] h2, html[lang=hi] h3, html[lang=hi] h4, html[lang=hi] h5, html[lang=hi] h6 { line-height: 2em; } _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
