User "Jack Phoenix" posted a comment on MediaWiki.r98701. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98701#c23650 Commit summary:
CreateAPage: initial changes to make this more compatible with 1.18 (committing so that Krinkle can make my JS suck a bit less ;): *moved inline (!) YUI (!!) JS to a file, made it more object-oriented and rewrote using pure DOM + jQuery **overlay is problematic **mw.msg() doesn't seem to be working **see all the stuff marked as FIXME in js/CreateAPage.js *removed two EasyTemplates that were just JavaScript with wfMsg() PHP bits stuck in *renamed some methods and variables *requires PHP 5.3+ due to the nasty hack I put into templates/templates-list.tmpl.php *bumped version number from 3.80 to 3.90 Comment: I don't think that the lack of message documentation is worth of a FIXME; [[Special:Code/MediaWiki/status]] says about the FIXME status: "Revision introduced a bug or is broken. It should be fixed or reverted." It would be fitting for this revision, but ''not due to message documentation''. This breaks CreateAPage's functionality a bit, but like I wrote in the commit message, I committed this so that Krinkle could see the JS, maybe play around with the extension locally and tell me what I'm doing wrong, why mw.msg() isn't working and why jquery.ui.dialog.js never gets loaded despite being a registered dependency. On the subject of message documentation: the status quo of message documentation reminds me of Special:UserRights and how much it used to suck (old-timers might remember Special:MakeSysop, Special:Desysop and Special:GiveRollback). You can see my take on the issue on pages like [[Extension:VoteNY#Internationalization]].<br />Remember, translators are most certainly not the only ones who should know about the i18n messages, but wiki administrators might also want to customize them for their needs. MediaWiki.org is a documentation wiki about the MediaWiki software and that's why I want message documentation to be done here instead of being put into the .i18n.php file — let's clutter up the i18n files with ''translations'' instead of things that just do not belong there. And as for the initial comment, I have to agree with MaxSem's comment on #mediawiki: [[w:Wikipedia:Don't template the regulars]]. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
