User "Krinkle" posted a comment on MediaWiki.r98563.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98563#c23653
Commit summary:
Followup r98500, conversion of the Javascript to use jQuery fully. It also
makes the Javascript work outside of debug=1 (oops)
There's a couple of WTF moments in the code, this is really due to some issues
with the PHP side of stuff. It really needs some TLC but for right now it
works, I'll come back to it before 1.19 and clean it up.
Comment:
Yes. There is a raw message being inserted between other html. Either use
<code>$('<li.....>').text( mw.msg() );</code> Or create a message object with
<code>mw.message( 'key' )</code> and call <code>mw.message( 'key'
).escaped()</code>. Both are useful depending on what the surrounding code
looks like.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
