User "Krinkle" changed the status of MediaWiki.r95870. Old Status: new New Status: deferred
User "Krinkle" also posted a comment on MediaWiki.r95870. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95870#c23684 Commit summary: Fix Uncaught TypeError: Cannot call method 'substr' of undefined * When changing the name of a category and saving it, this error is thrown from $.ucFirst. Although the script does check for it to be a string, what happens between that and ucFirst is broken. It should always set 'category' of splitresult[0], not just if there is a [1] (=sortkey). Otherwise, if there is no sortkey, 'category' is undefined. * Also updated outdated comment saying that variable sortkey contains wikitext between "[[Category:Foo" and "]]" (which implies it includes the pipe, which is no longer true) Follows-up r93351. Comment: AjaxCategories moved out of core. Marking deferred for now. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
