User "Brion VIBBER" changed the status of MediaWiki.r98927. Old Status: new New Status: ok
User "Brion VIBBER" also posted a comment on MediaWiki.r98927. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98927#c23751 Commit summary: (bug 31179) Fixed problems with undeletion making bad page rows: * Moved up isCountable() call, since insertOn() sets the page ID, it safer to do this call first. It now uses master DB data, as it should for reads to write data. Furthermore, calling it after insertOn() was triggered loadPageData() on a slave, breaking the page ID cache just set in insertOn(). * Preemptively call loadPageData( 'fromdbmaster' ) as Article::doEdit() does (r98880) to avoid any lazy loading from the slave which can corrupt the page ID cache. Comment: Should help -- fingers crossed. :) Change to the isCountable() fetch position shouldn't actually make a difference as we haven't actually updated the article's page record with the new latest revision -- but I think it's clearer to ask for it up front the new way. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
