User "Krinkle" posted a comment on MediaWiki.r98876.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98876#c23771
Commit summary:

[RL2] Address r98729 CR (Title::makeSafeTitle possibly returning null)
* Wasn't sure whether to use instanceof, !is_null, is_object or just casting to 
boolean. Roan to just cast to boolean
* Adding checks were missing and change one lost is_object check to cast to 
boolean too.
* While at it, making gadgetlinks-section re-use the Title object for the 
gadget definition page instead of re-creating it.

Comment:

ViewVC gives a nicer diff :)

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to