User "RussNelson" posted a comment on MediaWiki.r98842. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98842#c23777 Commit summary:
Do not propagate Swift exceptions up to the user. Fix a few overenthusiastic visibility modifiers. Comment: It's not right. Well, it's not wrong either. I need to figure out how to test this code before I enable it. So far I can't see a clean test case, but will keep looking for a few hours. May need to knuckle down and test php unit tests. I prefer end-to-end tests, but if there's no clean way to get to the end, better a unit test. Not making things public that weren't already (but not marked as such). I had over-hidden a few functions in my enthusiasm to mark things as private and protected. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
