User "Brion VIBBER" changed the status of MediaWiki.r82645. Old Status: resolved New Status: fixme
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82645 Commit summary: * Rewrote StripState to not use ReplacementArray. The memory usage of FSS was excessive when there were many (>10k) strip items. I used preg_replace_callback(), which is slower than strtr() in the simplest case, but much faster than it when the markers have different lengths, which they usually do. * It was not necessary to preserve the $stripState->general->setPair() interface since it wasn't used by any extensions. * Moved StripState to its own file. * Refactored serialiseHalfParsedText() and unserialiseHalfParsedText() so that the bulk of the functionality is in the relevant modules, instead of using scary direct access to object member variables. Made it support the new StripState. It seemed like a lot of work to go to to support an "emergency optimisation" feature in Cite. Cite updates will be in a subsequent commit. * Fixed spelling of serialiseHalfParsedText() and unserialiseHalfParsedText(), there is unavoidable interface breakage anyway, due to cache object versioning. * Moved transparent tags to their own function, as requested in a fixme comment. * Added documentation for markerSkipCallback(). * Removed OnlyIncludeReplacer, unused since MW 1.12. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
