User "Midom" posted a comment on MediaWiki.r99061.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99061#c23868
Commit summary:

MFT r94199

Comment:

"avoid not caching data because of stupid memcached heuristics on ttl value"

see, heuristics doesn't mean "handling very high TTL values very well", 
Wikipedia defines it as:

"Heuristic ( /hjʉˈrɪstɨk/; or heuristics; Greek: "Εὑρίσκω", "find" or 
"discover") refers to experience-based techniques for problem solving, 
learning, and discovery. Heuristic methods are used to speed up the process of 
finding a satisfactory solution, where an exhaustive search is impractical. 
Examples of this method include using a "rule of thumb", an educated guess, an 
intuitive judgment, or common sense."

What it means here, is that I'm overwriting some kind of rule of thumb and 
deliberately want to leave a high value by establishing another boundary in the 
check.

Why would I want that? 

Because heuristics decide whether TTL is relative or absolute, and we still 
allow that. I was trying to make the change without enforcing bad behavior.

When you dropped the range check, you potentially broke something, without 
thinking much, and blaming that you were not informed enough. 
You were informed, you had the check in the code, which was based on whatever I 
was contemplating on at that time. 

Cheers! ;-)

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to