User "Awjrichards" changed the status of MediaWiki.r98470. Old Status: new New Status: ok
User "Awjrichards" also posted a comment on MediaWiki.r98470. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98470#c23956 Commit summary: Added a form for BANK_TRANSFER. Comment: <pre> + // we only want to load this JS if the form is being rendered + $this->loadValidateJs(); // validation JS + + $this->loadPlaceholders(); </pre> These should probably be called before the parent constructor. loadPlaceholders() will need to be replaced with the ResourceLoader-ified version of this method that was just added to trunk, though I imagine we'll take care of this when merging this branch back into trunk. <pre> + //$form .= Html::hidden( $field, $value ); + //$form .= Xml::closeElement( 'div' ); // close div#right-column </pre> Are these supposed to be commented out? I don't see $value used anywhere else in that function. Also, I wonder if we should change the element ids to something other than 'payflowpro-' for this, but perhaps that's a non-issue. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
