User "Awjrichards" changed the status of MediaWiki.r98478. Old Status: new New Status: fixme
User "Awjrichards" also posted a comment on MediaWiki.r98478. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98478#c23958 Commit summary: Added transaction_type variable with a setter and a getter for the value. Comment: <pre> + public function setTransactionType( $transaction_type ) { + + $transaction_type = empty( $transaction_type ) ? false : $transaction_type; + + $this->transaction_type = $transaction_type; + } </pre> IIRC, elsewhere you're pulling transaction_type with $wgGetText( 'transaction_type', null ); While probably not a big deal, and perhaps even remedied by this function, it would be nice to keep an empty transaction_type value consistent. Feel free to argue this! _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
