User "MaxSem" posted a comment on MediaWiki.r99355. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99355#c24020 Commit summary:
initial import of TwitterLogin extension Comment: * You're duplicating functionality of core's Http class, which also works without cURL installed. * <tt>user_id</tt> field name duplicates one from user table, that's why we [[Manual:Coding_conventions#Table_naming|recommend to prefix field names uniquely for every table]]. * <tt>$this->_oauthCallback = 'https://'.$_SERVER['SERVER_NAME'].$wgScriptPath.'/index.php/Special:TwitterLogin/callback';</tt> will break for installations: ** with .php5 extension used ** without pathinfo :recommend using <tt>$this->getTitle( 'callback' )->getFullURL()</tt> _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
