User "Krinkle" posted a comment on MediaWiki.r44981. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/44981#c24049 Commit summary:
Pull back r44972 for now "(Bug 16677) Media: view URLs should HTTP-redirect to canonical File: namespace" r44972 isn't quite behaving transparently; non-view URLs are also being redirected to the raw view page, so for instance an ?action=edit or diff or whatever gets lost. See for example: http://en.wikipedia.org/wiki/Image:Wiki.png?action=edit http://en.wikipedia.org/wiki/Media:Wiki.png?action=edit these both currently behave just like: http://en.wikipedia.org/wiki/File:Wiki.png?action=edit while with this patch the Media: one would unexpectedly redirect to the view URL. The redirection should probably just be done where other existing normalization is... perhaps all that's actually needed is just to replace a Media: Title with the equivalent File: one when initializing the title in the first place, and the existing normalization-redirection will take care of it. Comment: A way to preserve the query would be nice :) During ResourceLoader2 I attempted to redirect Special:Gadgets/ to Special:Gadgets (in case no sub page parameter is provided), but I undid that because depending on the implementation I either got stuck with an infinite redirect of a lot of bogus in the url. I use OutputPage::redirect, Title:getFullUrl and something with WebRequest::getQueryValues. The problem was that the 'title' query parameter was someone ending up being added after the one in the current url, and the one in the current url via mod_rewrite/articlepath is internally interpreted as 'title' as well. So the URL looked like title=Special:Gadgets/&title=Special:Gadgets. I tried unsetting ['title'] but somehow got re-added. A way to redirect to a title with an option to preserve query (and still have it be fixed afterwards to apply article/action paths were relevant) would be really nice :) _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
