User "Nikerabbit" posted a comment on MediaWiki.r99466. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99466#c24093 Commit summary:
Testcases for isValidUserName method of User.php. There are many cases this method will fail for non-latin languages, but not added now since there are bugs reported on that already and results a rewrite of the method as per UAX 31 standard. Comment: Would it make sense to use a data provider instead? See http://sebastian-bergmann.de/archives/702-Data-Providers-in-PHPUnit-3.2.html The comments could be moved to third parameter in assertions, which will then be printed if test fails. Also has mixed indentation. I think it also makes sense to add tests that do not work currently, just mark them as broken. This way you can specify beforehand what should work and test against it. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
