User "RussNelson" posted a comment on MediaWiki.r99441. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99441#c24180 Commit summary:
Remove some dupe comments Member variables Comment: Hrm. If you protect it all the way down, through LocalFile.php and File.php, everything that phpunit tests still works. I don't know of any reason why it needs to be public. It wasn't *marked* as public in File.php (an abstract class), but neither was it protected. If you want to go ahead and protect it, then it should be sufficient to mark it as protected in File.php, no? _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
