User "TheDJ" posted a comment on MediaWiki.r96261. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96261#c24339 Commit summary:
* Mark underline css as !important. It should override other css (such as the css added in r91432) if the user specifically selected that option. * Fix css flipping: for Simple, it still depended on the content language (however, no css actually needs flipping there). For Standard/CologneBlue, I re-added flipping even though it's not needed there either. Just in case css is added that does need flipping, so it is future-proof :). Consequently, I added noflip to the existing css. * For this flipping I added a parameter to addInlineStyle(), which I assume to be useful in other cases as well Comment: "Mark underline css as !important. It should override other css" This broke the "nounderlines" css styling on english wikipedia, which was used to remove underlines from certain glyphs with diacritics etc. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
