User "Tim Starling" changed the status of MediaWiki.r93720. Old Status: new New Status: fixme
User "Tim Starling" also posted a comment on MediaWiki.r93720. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93720#c24376 Commit summary: Extend upload api adding an option to upload files in chunks, using UploadStash to track the unfinished upload. Comment: I can't see any synchronisation here. NFS doesn't have locking or atomic append operations, so what's to stop chunks from becoming interleaved or overwriting each other? Also, filesize() on a file on NFS could potentially hit the stat cache in the NFS client, giving a delay of up to 2 seconds in file size updates. Say if you upload 3 chunks, and they are handled by 2 servers: # Server A # Server B # Server A if this occurs in less than the stat cache expiry time, the third chunk will get a file size that doesn't include the second chunk. It probably makes sense to use the database for synchronisation instead of relying on FileRepo. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
