User "NeilK" posted a comment on MediaWiki.r93720.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93720#c24509
Commit summary:

Extend upload api adding an option to upload files in chunks,
using UploadStash to track the unfinished upload.

Comment:

Replying to myself... I see that you already understood the offset thing and 
your point was that it wasn't a reliable way to determine if it was okay to 
append a chunk. 

I've read a bit more about how NFS handles these situations. 
(http://nfs.sourceforge.net/#faq_a8). Things seem to have gotten a lot better 
in recent Linux NFS clients, and to some extent the problem of cached stat data 
and non-atomic appends might be mitigated by using locks, which suck less than 
they did. But this is a bit out of my depth; perhaps the simplest thing is to 
use MySQL to synchronize writers.

While we're thinking about this stuff, we should also use PHP clearstatcache().

We had another proposal where the server asked the browser to just supply 
whatever chunk came after the file's current size. That's in some ways a lot 
easier to coordinate.


_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to