User "Helder.wiki" posted a comment on MediaWiki.r100239.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100239#c24573
Commit summary:

Follow-up r82285: we should not apply case conversion to these names, because 
it's unintuitive and potentially risky when they could theoretically contain 
weird characters.  It was necessary before r86508, but not now there is a 
prefix meaning the group name is not at the start of the title.  Plus the 
default messages are already at the lowercase titles.

Comment:

Er... I think this needs a small fix: "$g" is not defined anymore but you are 
still using it on:
 $pages["MediaWiki:Group-$g.js"]
 $pages["MediaWiki:Group-$g.css"]
It should be replaced by "$group", I think.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to