User "Awjrichards" changed the status of MediaWiki.r97115.

Old Status: new
New Status: fixme

User "Awjrichards" also posted a comment on MediaWiki.r97115.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97115#c24666
Commit summary:

Removing GC's ability to send credit card info

Comment:

I must've forgotten to lave a comment.

<pre>
+               $this->postdata['returnto'] = $returnto . "?order_id=" . 
$this->postdata['order_id'];
</pre>

Query strings like this should be constructed with MW magic eg wfArrayToCGI(). 
$this->postdata['order_id'] should also be escaped.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to