User "Aaron Schulz" posted a comment on MediaWiki.r100164.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100164#c24674
Commit summary:

Updated the architecture for the FileBackend to support multiple data stores 
registered at the same time through and external interface

Comment:

IMO:
I'd rather see a subclass of AbstractFileStore called FileBackendMultiWrite. 
AbstractFileStore should be renamed to AbstractFileBackend for consistency and 
made into an interface.

Also the registerDataStoreModule() functionality should just go in a factory 
constructor, as we don't backends getting tacked on throughout execution.


_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to