User "Kaldari" changed the status of MediaWiki.r95923. Old Status: new New Status: fixme
User "Kaldari" also posted a comment on MediaWiki.r95923. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95923#c24675 Commit summary: More refactoring. The new globalcollect gateway is now inheriting from the common gateway abstract class. (Also cleaned up the formatting more than somewhat) Comment: It looks like parseXMLResponse has been replaced with other things so that is moot. Is there a reason we want to get and set the current transaction in the same method. This makes the code confusing, in my opinion. Would there be any downside to splitting it into 2 methods (other than a few extra lines of code)? Some of these methods need comment descriptions as their purpose isn't obvious without carefully reading the code, for example, buildTransactionNodes and appendNodeIfValue. And since do_transaction is the most important method here, it should probably have at least a basic description. Looks like there's lots of defensive programming here, which is great, and your comments are hilarious :) _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
