User "Khorn (WMF)" posted a comment on MediaWiki.r95923. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95923#c24683 Commit summary:
More refactoring. The new globalcollect gateway is now inheriting from the common gateway abstract class. (Also cleaned up the formatting more than somewhat) Comment: Basically, the only reason I did current transaction as both a get and a set, was so I could take advantage of a static variable in the one function. In short: It was quicker. But as it seems to be confusing, I have no problem moving it somewhere external and having a get/set pair. Additionally: Proper function documentation has been on my TODO list for about a month now. I promise it's moving up the priority stack. But, yes: These things should absolutely be fixed. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
