User "Brion VIBBER" changed the status of MediaWiki.r100426. Old Status: deferred New Status: fixme
User "Brion VIBBER" also posted a comment on MediaWiki.r100426. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100426#c24684 Commit summary: Add patch which fixes pdfinfo to respect page rotation when reporting the size. Add if(!isset()) to configuration. Render directly to thumbnails without using ImageMagick and without the need to specify DPI. Link thumbnails to individual pages of PDF. Add GhostScript options for better rendering. Comment: This seems to munge a bunch of stuff together which should be looked at separately. * multiple page thumbnails -- what does this even mean? any usability issues? safety? will this work with the thumbnail 404 handlers etc? do we want this at all? * rotation fixing -- probably nice but needs testing * direct rendering -- unsure whether this is good or not; why didn't we do it direct in the first place? any issues with file size, sharpness etc? * lots of register_globals vulnerabilities -- needs immediate revert * there appears to be a patch for a third-party utility, which it sounds kinda like it's required to make the rotation actually work? if so this is kind of a killer as it makes deployment MUCH harder _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
