User "Kaldari" posted a comment on MediaWiki.r98202.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98202#c24685
Commit summary:
More refactoring work for the gateway adapters, mostly surrounding the special
page itself.
Comment:
+ if ( empty( $val ) ) {
Don't you want...
if ( !$val ) {
...or...
if ( $val === '' ) {
...instead?
We don't usually use empty() unless we really need to suppress errors for some
reason. Otherwise ! is functionally equivalent (even for 0 values).
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview