User "Nikerabbit" posted a comment on MediaWiki.r100501. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100501#c24717 Commit summary:
Work in progress, extension which adds a status if user is online, there is still a lot to do, also it's my first extension so it's little bit ugly :) Comment: Here're some tips for moving from a little bit ugly to awesomeness :D # Weird indentation, also mixes tabs and spaces. # We don't use ?> at the end of the file. # Messages cannot have trailing whitespace # If possible, make the message look at least like $1 is now $2 # Hooks should return true or false, or string, but not zero. # language::getMessageFromDB isn't a static function, use wfMessage or some other variant of wfMsg* instead. # instead of $ns == "3" use constants like NS_USER_TALK # Why are you calling $db->SelectDB() all the time? # The usual naming convention is $dbr for slaves and $dbw for masters. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
