User "Jack Phoenix" changed the status of MediaWiki.r100269. Old Status: fixme New Status: new
User "Jack Phoenix" also posted a comment on MediaWiki.r100269. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100269#c24735 Commit summary: SocialProfile: allow specifying and showing the user's year of birth on social profile pages. Patch by Rinat Silnov. To use this feature, go to Special:UpdateProfile/preferences, toggle the new "Show year of birth" option, save preferences, then add your birthday on Special:UpdateProfile, save again and now your birthday will be shown on your profile. Do note that because of the mw.loader.using() call in UserProfile/UpdateProfile.js, this breaks backwards compatibility with pre-ResourceLoader MediaWikis (that is, 1.16 and older). I don't know if this works with 1.17, but I tested this against the current 1.18 branch. Comment: I agree that it's not the best possible format for most of the world, but thankfully it isn't such a big issue, due to the jQuery datepicker. Maybe Rinat would be able to comment more on that, as this is his code. [[Special:Code/MediaWiki/status]] states about the FIXME status: "Revision introduced a bug or is broken. It should be fixed or reverted." — this clearly is not the case with this revision, unless there's a regression or a bug that hasn't been reported yet. Message documentation or the lack of it is at most a to-do, not a FIXME. Resetting status back to new. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
