User "Tim Starling" changed the status of MediaWiki.r99911.

Old Status: new
New Status: fixme

User "Tim Starling" also posted a comment on MediaWiki.r99911.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99911#c24740
Commit summary:

Per bug 28135, disable $wgMaxImageArea check when transforming using a hook, 
and enable the check for non IM scalers.

Comment:

Moving the area check from normaliseParams() to doTransform() after the 
TRANSFORM_LATER case means that it will be done by the 404 handler only. The 
parser will generate valid links to image, and thumb.php will generate an 
uncacheable HTTP 500 error, meaning that scaling will be retried every time 
someone views the page. If the page is a popular one, that could be many times 
per second. That's one of the reasons why it was in normaliseParams().

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to