User "Hashar" posted a comment on MediaWiki.r81571. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81571#c24746 Commit summary:
Html::expandAttributes( array( 'foo' => null ) ); ' foo=""' -> '' Outputting ' foo="" on `foo = null` promotes the writing of overly verbose code to avoid it, and ugly methods like our old Linker::getLinkAttributesInternal, both of which are completely counter to the purpose of Html::. Comment: removing tag 'needs-php-test' since I have added tests. _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
